WIP, for 4.2.1: Shovel tests #14794
Draft
WIP, for 4.2.1: Shovel tests #14794
+717
−876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is the source side of the shovel that must handle the basic.cancel message from the source queue. This fix makes 091-10 and 091-local work, handling the basic.cancel and restarting the shovel when required.
AMQP1.0 doesn't emit metrics right after the initial connection, it needs something to happen in the shovel to emit the first blocked status report. By emitting metrics on the first running report, all shovels will report the initial metrics as soon as they are initialised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.