DO NOT MERGE YET Do not wait before trying to dispatch a chunk of messages #14766
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A stream connection waited artificially before retrying to send a chunk after Osiris returned an end_of_stream result. It was initially to let some messages arrive in the stream. This wait time does not seem necessary and can be even counter productive. A connection with many consumers on the same stream that gets published to can get many notifications from Osiris and ended up waiting for each consumers. This can make the connection blocks for several seconds and unable to perform other operations like simple RPC. This commit removes the wait time. References rabbitmq/rabbitmq-stream-java-client#863
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stream connection waited artificially before retrying to send a chunk after Osiris returned an end_of_stream result. It was initially to let some messages arrive in the stream.
This wait time does not seem necessary and can be even counter productive. A connection with many consumers on the same stream that gets published to can get many notifications from Osiris and ended up waiting for each consumers. This can make the connection blocks for several seconds and unable to perform other operations like simple RPC.
This commit removes the wait time.
References rabbitmq/rabbitmq-stream-java-client#863