Implement LDAP credentials validation via HTTP API (backport #14414) #14640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion #14244 These changes will allow a user to make an HTTP API request to... ``` /api/ldap/validate/simple-bind ``` ...with an appropriate JSON body, and the plugin will attempt a connection to the specified LDAP server using the provided credentials. This allows validation that a connection can be made to an LDAP server from a RabbitMQ cluster environment. * Add code and tests for `eldap:simple_bind` validation. * Add support for testing TLS connections to OpenLDAP * Add support for validating TLS related configuration via `/ldap/validate/simple-bind` * Add support for various TLS options: * versions * depth * multiple CA cert pem data * Fall back to system certs if neither `cacertfile` nor `cacerts_pem_data` are provided to the `simple-bind` validation. * Add `ssl_hostname_verification` support. * Return 422 when auth fails * Add more informative information when connection fails * Add more tests with invalid input * Catch parsing errors * Tests for edge-cases for password / user_dn * Add test for use_ssl + use_starttls combo * Add test for ssl_options.depth validation * Add validation tests for server_name_indication (cherry picked from commit 9a4cb9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion #14244
These changes will allow a user to make an HTTP API request to...
...with an appropriate JSON body, and the plugin will attempt a connection to the specified LDAP server using the provided credentials. This allows validation that a connection can be made to an LDAP server from a RabbitMQ cluster environment.
This is an automatic backport of pull request #14414 done by Mergify.