Khepri: Remove setup retries (backport #13533) #13716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] Khepri already managed retries if needed, we can just use a timeout. Note that the timeout was already bumped to a more appropriate 5 minutes, which also matches what we had with Mnesia. However, with 10 retries by default, it meant that this timeout at the end of `init/1` would thus be 5 * 10 = 50 minutes. (cherry picked from commit 67d9d89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Khepri already managed retries if needed, we can just use a timeout.
Note that the timeout was already bumped to a more appropriate 5 minutes, which also matches what we had with Mnesia. However, with 10 retries by default, it meant that this timeout at the end of
init/1would thus be 5 * 10 = 50 minutes.This is an automatic backport of pull request #13533 done by Mergify.