Fix flake on selenium basic-auth suite due to timing issue #13197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
changed the title
MarcialRosales
force-pushed
the
fix-selenium-flake
branch
2 times, most recently
from
c9ded04 to
eec589b
Compare
MarcialRosales
added a commit
that referenced
this pull request
Feb 5, 2025
MarcialRosales
force-pushed
the
fix-selenium-flake
branch
from
eec589b to
bb571ad
Compare
MarcialRosales
added a commit
that referenced
this pull request
Feb 7, 2025
MarcialRosales
added a commit
that referenced
this pull request
Feb 11, 2025
MarcialRosales
added a commit
that referenced
this pull request
Feb 11, 2025
MarcialRosales
added a commit
that referenced
this pull request
Feb 12, 2025
MarcialRosales
force-pushed
the
fix-selenium-flake
branch
2 times, most recently
from
2ae7151 to
f0a5b85
Compare
ansd
pushed a commit
that referenced
this pull request
Feb 12, 2025
* Separate invalid client test from the valid one * Apply same changes from pr #13197 * Deal with stalereferences caused by timing issues looking up objects in the DOM * Unlink before assertion
ansd
pushed a commit
that referenced
this pull request
Feb 12, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
* Separate invalid client test from the valid one * Apply same changes from pr #13197 * Deal with stalereferences caused by timing issues looking up objects in the DOM * Unlink before assertion (cherry picked from commit 2ab890f) (cherry picked from commit e84a516) # Conflicts: # deps/rabbitmq_mqtt/test/auth_SUITE.erl # selenium/package.json
michaelklishin
force-pushed
the
fix-selenium-flake
branch
from
f0a5b85 to
fdaf16b
Compare
Collaborator
|
I don't know why GitHub has decided to close this PR, I've only tried to rebase it :) will re-submit. |
Collaborator
|
According to GitHub, the tip of this branch was previously merged in #13180. @MarcialRosales please have a look. |
Contributor
Author
|
it could be because I applied these changes also in the PR that addressed a flake on the mqtt module .. Maybe i tried it there just to see it did work too .. and i did not removed it at end. I wanted to have two separate PRs for two different flakes. |
michaelklishin
pushed a commit
that referenced
this pull request
Mar 17, 2025
* Separate invalid client test from the valid one * Apply same changes from pr #13197 * Deal with stalereferences caused by timing issues looking up objects in the DOM * Unlink before assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flake due to timing issue and bump up chromedriver
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply