-
Notifications
You must be signed in to change notification settings - Fork 4k
CQ: Make CQ shared store compaction fast #10696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
961da12 to
f586d3a
Compare
b24763f to
aaf76aa
Compare
Doing that from ets is far too expensive unfortunately.
This is to be more thorough and avoid losing sight of a message moved during compaction.
aaf76aa to
74b9811
Compare
|
Test results: https://grafana.lionhead.rabbitmq.com/goto/3Bgb8QASR?orgId=1 While there are other differences - some small performance regressions and some improvements, the most important is that there are no more memory spikes like this: This spikes correlate with the issue #10681 (at least in my testing) since they are a caused by a backlog of compaction requests. Other notable differences:
|
|
Thank you! Better compaction scheduling is something we can improve at a later time. |
CQ: Make shared store compaction fast (backport #10696)


This PR does 3 things:
Types of Changes