Crash while getting allocatedUserChannels

[jackkudo]

Describe the bug

In some cases the app crashes. I got the log from the Test Flight then saw the issue come from the function

• (NSArray *)allocatedUserChannels in class RMQMultipleChannelAllocator.m

Seems like in that function it tried to remove the first element in case the array is empty.

Reproduction steps

No specific steps. Sometimes it happens.

Expected behavior

Must check the array length should be greater than 0 then remove the first element as the current logic.

Additional context

[michaelklishin]

A fix was contributed by @jackkudo in #237.

[jackkudo]

Hi @michaelklishin Can you release a new version for this fix?

[michaelklishin]

@jackkudo I can tag a new version later this week if that's what you mean.

[jackkudo]

Yes. That's good. Because now our application it crashes sometimes.

Thanks in advance!
@michaelklishin

[michaelklishin]

@jackkudo done.

If you'd like to help maintain this project, I'd appreciate some input on #231. We don't have to use Carthage the same way we do (or at all), of course.

And I'd be happy to grant you push permissions to this repo if you have some cycles to help. For many years now my focus is almost entirely on RabbitMQ itself, not so much on client libraries.

[jackkudo]

@michaelklishin Thank you.

I didn't see the new version while fetching via CocoaPods. Can you check why?

[michaelklishin]

Because I have only tagged this release. I haven't done a CocoaPods release in 18 months so it will take a bit of time to figure out how that's done today, and if the build system even can accommodate a proper release.

[jackkudo]

Yes. No problem. I can wait even in next week to have a new version in CocoaPods. Can you do it?

[michaelklishin]

@jackkudo like I said, I do not work on iOS or macOS projects so it takes me a long time to figure out things such as this one (which is an error that prevents pod lib lint and pod trunk push from succeeding right now).

[jackkudo]

Ah ok. So is there any way that I can update the latest version without CocoaPods?

[michaelklishin]

@jackkudo you can help me fix the error in pod lib lint.

According to CocoaPods/CocoaPods#922 (comment), Cocoapods no longer support source dependencies.

[jackkudo]

Hi @michaelklishin I found an alternative way to fetch the latest of RabbitMQ by CocoaPods. Using this line
pod 'RMQClient', :git => 'https://github.com/rabbitmq/rabbitmq-objc-client.git' instead of
pod 'RMQClient'

And now it works.
So, you don't need to care about the issue above.