Add Netty-based frame handler #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better performance? |
Early tests with a simplistic workload showed a 10% increase in throughput but increased latency (compared to blocking IO). With a limited rate 10 K msg / s, the latency is comparable to the blocking IO. The goal is to make Netty the default (and maybe only) IO layer. This way we could get rid of a significant amount of code (our NIO layer) and benefit from Netty flexibility (NIO by default, but also native IO options). |
This commit adds a Netty-based frame handler. All network IO are based on Netty when this frame handler is in use. The client library can benefit of all the flexibility and advantages of Netty: simple API, pluggable IO layer (Java NIO by default, or e.g. native Epoll on Linux). The Netty frame handler deprecates the internal one using Java NIO. The blocking IO frame handler is still the default one in 5.x. The Netty frame handler should be the only one in 6.x. Fixes #1664
acogoluegnes
force-pushed
the
netty-frame-handler
branch
from
6caf2a8 to
74f538d
Compare
acogoluegnes
added a commit
to rabbitmq/rabbitmq-perf-test
that referenced
this pull request
Aug 6, 2025
acogoluegnes
added a commit
to rabbitmq/rabbitmq-perf-test
that referenced
this pull request
Aug 6, 2025
This commit adds support for the Netty-based frame handler that was added in RabbitMQ AMQP 091 Java client 5.27.0. New options: * --netty: to activate Netty with the defaults * --netty-threads: to set the number of threads used in the event loop * --netty-epoll: to use the native epoll support (Linux x86-64) * --netty-kqueue: to use the native kqueue support (macOS aarch64) This change also deprecates the options related to Java NIO. References rabbitmq/rabbitmq-java-client#1663 Fixes #856
acogoluegnes
added a commit
that referenced
this pull request
Aug 7, 2025
Part of the back-pressure mechanism. References #1663
acogoluegnes
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Aug 7, 2025
acogoluegnes
added a commit
that referenced
this pull request
Aug 7, 2025
Having a method like useNetty() is not necessary as netty() activates Netty as well. Moreover useNetty() does not allow to set the EventLoopGroup, which is essential to configure when using Netty. References #1663 (cherry picked from commit aed8d84) Conflicts: src/main/java/com/rabbitmq/client/ConnectionFactory.java
acogoluegnes
added a commit
that referenced
this pull request
Aug 7, 2025
Having a method like useNetty() is not necessary as netty() activates Netty as well. Moreover useNetty() does not allow to set the EventLoopGroup, which is essential to configure when using Netty. References #1663
acogoluegnes
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Aug 7, 2025
acogoluegnes
added a commit
that referenced
this pull request
Aug 14, 2025
Fix back-pressure in Netty frame handler References #1663
acogoluegnes
added a commit
that referenced
this pull request
Sep 5, 2025
For Netty. Make sure that connection shutdown sequence is not executed in the IO event loop if recovery follows. Recovery kicks in the shutdown sequence, so we could end up with a deadlock if the new connection is allocated to the same event loop. References #1663
acogoluegnes
added a commit
that referenced
this pull request
Sep 8, 2025
No need to try to connect if the event loop group was shut down. This also triggers an infinite cycle of connection recovery in the following case: connection disconnected, recovery starts, event loop group closed, new connection attempt, Netty channel created and becomes inactive immediately, recovery restarts, etc. References #1663
acogoluegnes
added a commit
that referenced
this pull request
Sep 8, 2025
No need to try to connect if the event loop group was shut down. This also triggers an infinite cycle of connection recovery in the following case: connection disconnected, recovery starts, event loop group closed, new connection attempt, Netty channel created and becomes inactive immediately, recovery restarts, etc. To avoid the recovery loop, stop recovery when the exception (IllegalStateException) is thrown. References #1663
acogoluegnes
added a commit
that referenced
this pull request
Sep 8, 2025
For Netty. Make sure that connection shutdown sequence is not executed in the IO event loop if recovery follows. Recovery kicks in the shutdown sequence, so we could end up with a deadlock if the new connection is allocated to the same event loop. References #1663 (cherry picked from commit cef9a48) Conflicts: src/main/java/com/rabbitmq/client/impl/Environment.java src/test/java/com/rabbitmq/client/test/TestUtils.java src/test/resources/logback-test.xml
acogoluegnes
added a commit
that referenced
this pull request
Sep 8, 2025
No need to try to connect if the event loop group was shut down. This also triggers an infinite cycle of connection recovery in the following case: connection disconnected, recovery starts, event loop group closed, new connection attempt, Netty channel created and becomes inactive immediately, recovery restarts, etc. To avoid the recovery loop, stop recovery when the exception (IllegalStateException) is thrown. References #1663 (cherry picked from commit 5da2fc3)
acogoluegnes
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Oct 16, 2025
acogoluegnes
added a commit
to rabbitmq/rabbitmq-website
that referenced
this pull request
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.