Better handle data loss in first chunk #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When data is lost in the first chunk ever written subsequent inits would detect this in the index correctly but position the segment at eof which is incorrect. This fix addressed that by ensuring the empty log case is handled correctly.
kjnilsson
force-pushed
the
first-chunk-data-loss-fix
branch
from
ab40d3d to
1f6733e
Compare
michaelklishin
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When data is lost in the first chunk ever written subsequent inits would detect this in the index correctly but position the segment at eof which is incorrect. This fix addressed that by ensuring the empty log case is handled correctly.