fixed max(), min(), range() for multiple inputs if one is non-finite #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Please add regresion tests |
|
Regression tests added and reverted to |
|
Is there anything more to do or can it be merged? |
| #' Generating sequence of integer64 values | ||
| #' | ||
| #' @param from integer64 scalar (in order to dispatch the integer64 method of [seq()] | ||
| #' @param from integer64 scalar (in order to dispatch the integer64 method of [seq()]) |
There was a problem hiding this comment.
Run roxygenize() for this to be cascaded to the man/ directory (or you can just edit it directly for this simple case)
I just need to find some time, hopefully this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #142
The example in issue #142 now works correctly.
I also fixed the behaviour that the warning is also shown in the case of range(NA_integer64_, na.rm=TRUE).
The same is applied to min.integer64 and max.integer64.