Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

Conversation

khughitt
Copy link
Contributor

Greetings!

I put together a PR to extend sysreqsdb to support Arch Linux and its derivatives that use PKGBUILD files.

Few quick notes:

  • In Arch, most libraries include their development headers, which is why you won't see any xx-devel packages.
  • Some of the packages (e.g. bowtie2) are part of a widely-used community repo (AUR). They use the same PKGBUILD format as normal arch packages though and often packages that start out on the community repo end up migrating to the officially-maintained core/extra repos.
  • I'm pretty sure 99% of the arch dependencies added should refer to the correct package and work as-expected. I did not test all of them, however, so it's possible there are some invalid ones as well. If users flag these though, I/others can fix the issues as they arise.

Thanks for your work on this useful package!

Cheers,
Keith

@gaborcsardi
Copy link
Contributor

Thanks! This is awesome, and I'll be happy to merge it.

Two issues. One, the JSON format is changing, to facilitate automatic checks, and to make the web app that does the matching simpler. See the V2 branch. We can still merge this now, and then add the Arch Linux entries to the V2 branch later.

Second, would you be interested adding an Arch Linux Docker builder at https://github.com/r-hub/rhub-linux-builders?

@khughitt
Copy link
Contributor Author

Hi Gabor,

Sounds good -- I'll check out the v2 branch and update the JSON files there when I have the chance.
I was already planning on adding an Arch Dockerfile to the builder repo. I'll look into that now.. :)

@khughitt
Copy link
Contributor Author

Gonna modify changes for this PR to use gcc instead of clang since gcc is used by default.

@khughitt khughitt mentioned this pull request Apr 26, 2019
Copy link
Contributor

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One important and 2 less important comments.

sysreqs/atk.json Outdated
"OSX/brew": "atk",
"PKGBUILD": "atk",
"RPM": "atk-devel"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but indentation is wrong here.

"PKGBUILD": "mpfr",
"OSX/brew": "mpfr",
"RPM": "mpfr-devel"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

"sysreqs": "/pkg(:-|)config/",
"platforms": {
"DEB": "pkg-config",
"PKGBUILD": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a typo here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching those! Should be fixed now..

@gaborcsardi gaborcsardi merged commit ae2f753 into r-hub:master May 1, 2019
@gaborcsardi
Copy link
Contributor

Deployed, seems to work well: https://sysreqs.r-hub.io/pkg/igraph/linux-x86_64-arch-gcc

["gmp","libxml2"]

@khughitt
Copy link
Contributor Author

khughitt commented May 1, 2019

Sounds good! Just let me know if you notice any issues down the road.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants