-
Notifications
You must be signed in to change notification settings - Fork 31
Add support for Arch Linux #58
Conversation
Thanks! This is awesome, and I'll be happy to merge it. Two issues. One, the JSON format is changing, to facilitate automatic checks, and to make the web app that does the matching simpler. See the V2 branch. We can still merge this now, and then add the Arch Linux entries to the V2 branch later. Second, would you be interested adding an Arch Linux Docker builder at https://github.com/r-hub/rhub-linux-builders? |
Hi Gabor, Sounds good -- I'll check out the v2 branch and update the JSON files there when I have the chance. |
Gonna modify changes for this PR to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One important and 2 less important comments.
sysreqs/atk.json
Outdated
"OSX/brew": "atk", | ||
"PKGBUILD": "atk", | ||
"RPM": "atk-devel" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, but indentation is wrong here.
sysreqs/libmpfr.json
Outdated
"PKGBUILD": "mpfr", | ||
"OSX/brew": "mpfr", | ||
"RPM": "mpfr-devel" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation.
sysreqs/pkgconfig.json
Outdated
"sysreqs": "/pkg(:-|)config/", | ||
"platforms": { | ||
"DEB": "pkg-config", | ||
"PKGBUILD": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a typo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching those! Should be fixed now..
Deployed, seems to work well: https://sysreqs.r-hub.io/pkg/igraph/linux-x86_64-arch-gcc ["gmp","libxml2"] |
Sounds good! Just let me know if you notice any issues down the road. |
Greetings!
I put together a PR to extend sysreqsdb to support Arch Linux and its derivatives that use PKGBUILD files.
Few quick notes:
xx-devel
packages.Thanks for your work on this useful package!
Cheers,
Keith