Skip to content

adding mssql support #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vandsh
Copy link

@vandsh vandsh commented Jul 21, 2025

making modifications to data-service to hopefully support MSSQL, not sure what else is needed on the front end to accomodate

@manisandro
Copy link
Member

Thanks for the PR.

As far as the data-service is concerned, I'd suggest transforming dataset_features-provider into a base class with the common logic (if any), and implement it for dataset_features_provider_postgres and dataset_features_provider. Then, you could dynamically load the dataset_features_provider based on the dataset backend.

This would allow splitting loading the mssql bits only in a Dockerfile.mssql variant, and not directly in the base variant, since not all users necessarily want the proprietary mssql driver in the data-service base image.

As far as other changes, you'll also need to extend the qwc-config-generator to handle mssql datasources, not just postgresql.

@vandsh
Copy link
Author

vandsh commented Jul 22, 2025

please also see qwc-services/qwc-config-generator#99

from attachments_service import AttachmentsService
from spatial_adapter import SpatialAdapter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unused?

@@ -9,7 +9,7 @@
from flask import json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this file is now also unused?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants