Index configuration update #4832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
force-pushed
the
index-update
branch
3 times, most recently
from
22b84ef to
fd98be6
Compare
rdettai
commented
Apr 9, 2024
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs
Outdated
Show resolved
Hide resolved
rdettai
force-pushed
the
index-update
branch
2 times, most recently
from
edcbcfe to
97ae2d9
Compare
guilload
reviewed
Apr 10, 2024
quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Outdated
Show resolved
Hide resolved
rdettai
force-pushed
the
index-update
branch
3 times, most recently
from
fa710dc to
4786f12
Compare
rdettai
commented
Apr 11, 2024
guilload
approved these changes
Apr 11, 2024
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-metastore/src/metastore/file_backed/file_backed_index/mod.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-metastore/src/metastore/postgres/metastore.rs
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Apr 15, 2024
This was referenced Apr 15, 2024
|
what has happened to this PR. right now I couldn't update retention policy in existing index like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an index update endpoint. For this first version, only
search_settingsandretetention_policycan be configured.Notes:
list_indexes_metadatacalls are not proxied through the control plane, so eachroot_searchgoes directly to the metastore to get thesearch_settingsat each request which means that these changes are immediately visible by searchesHow was this PR tested?
This PR has a good unit test coverage. The fact that
search_settingsupdates are immediately taken into account is covered by an integration test.I also tested that the openapi spec is correctly rendered by swagger