1099 cli ingest cleanup cache #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Closes #1099 |
added 4 commits
March 21, 2022 16:48
…ickwit-oss/quickwit into 1099_cli_ingest_cleanup_cache merge
Collaborator
|
@PSeitz can you review? |
PSeitz
reviewed
Mar 22, 2022
PSeitz
reviewed
Mar 22, 2022
Collaborator
|
Thanks for the PR! I left some comments. Can you also add a test in quickwick-cli/tests/cli.rs? |
added 2 commits
March 22, 2022 08:48
Author
|
thanks i added the changes, still improving the test |
PSeitz
reviewed
Mar 23, 2022
Collaborator
|
Looks good so far, but the tests are failing. |
Author
|
yea i'm aware, will update |
PSeitz
approved these changes
Mar 27, 2022
Collaborator
|
Looks good, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add clean_cache argument to ingest cli
./quickwit index ingest --index hdfs-logs --clean_cache
How was this PR tested?
Describe how you tested this PR.