Remove getopt dependency and getopt_compat.h #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
commented
Mar 23, 2025
Comment on lines
-444
to
+441
| char *opt_arg = NULL; | ||
| char *optarg = NULL; |
There was a problem hiding this comment.
Renamed for consistency (if you call optind optind, then call optarg optarg, amirite?)
| break; | ||
| case 'n': | ||
| script_name = optarg; | ||
| while (optind < argc && *argv[optind] == '-') { |
There was a problem hiding this comment.
Stopping on - is maybe not useful for qjsc now, but I decided to keep it for consistency with qjs.
Potentially useful in the future to bake in arguments to the compiled script somehow?
Remove the use of getopt() from qjsc. Parse command line arguments the same way qjs does. As a bonus, teach the -S (stack size) option about size suffixes, just like qjs. `qjsc -S 2M -o x.c x.js` now works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of getopt() from qjsc. Parse command line arguments the same way qjs does.
As a bonus, teach the -S (stack size) option about size suffixes, just like qjs.
qjsc -S 2M -o x.c x.jsnow works.