Track line and column numbers for expressions #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
commented
Jan 2, 2025
|
|
||
| try { | ||
| throw new Error(""); // line 10, column 15 | ||
| throw new Error(""); // line 10, column 19 |
There was a problem hiding this comment.
Back to what it was.
saghul
approved these changes
Jan 2, 2025
|
Hrm, updating |
Commit 73cc00e reduced the number of emitted source locations a great deal but it resulted in at least one observable regression: export default async function f() { return "abc" + x } f() // ReferenceError should point to 2:20 but pointed to 1:1 Emit source locations for expressions again. Increases the average number of source locations by about 15%. Non-scientifically tested by counting source locations emitted when parsing the test suite before and after. No test because we currently cannot easily test stack traces coming from module imports. Fixes: quickjs-ng#779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 73cc00e reduced the number of emitted source locations a great deal but it resulted in at least one observable regression:
Emit source locations for expressions again. Increases the average number of source locations by about 15%. Non-scientifically tested by counting source locations emitted when parsing the test suite before and after.
No test because we currently cannot easily test stack traces coming from module imports.
Fixes: #779