regexp: fixed the zero advance logic in quantifiers #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
force-pushed
the
zero-advance-logic-in-quantifiers
branch
from
442842d to
8f6b41e
Compare
saghul
commented
Sep 13, 2024
| } BCTagEnum; | ||
|
|
||
| #define BC_VERSION 13 | ||
| #define BC_VERSION 14 |
There was a problem hiding this comment.
The generated bytecode changed, so I bumped the version.
bnoordhuis
approved these changes
Sep 14, 2024
Comment on lines
+1653
to
+1654
| s->byte_code.buf[pos++] = REOP_push_char_pos; | ||
| re_emit_op(s, REOP_check_advance); |
There was a problem hiding this comment.
I don't fully understand why this puts the REOP_check_advance at the end of the buffer while everything else is inserted before the end. Is pos == s->byte_code.size on the second line?
There was a problem hiding this comment.
I'll admit I have no idea, I just ported the fix and ran the tests 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: bellard/quickjs@10fc744