Expose public equality comparison and sameness public API. #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `JS_IsLooselyEqual` - add `JS_IsStrictlyEqual` - add `JS_IsSameValue` - add `JS_IsSameValueZero`
saghul
reviewed
Apr 12, 2024
bnoordhuis
reviewed
Apr 12, 2024
quickjs.c
Outdated
Comment on lines
51827
to
51828
| JSValue isEqual = sp[0]; | ||
| res = JS_ToBool(ctx, isEqual); |
There was a problem hiding this comment.
Suggested change
| JSValue isEqual = sp[0]; | |
| res = JS_ToBool(ctx, isEqual); | |
| res = JS_ToBoolFree(ctx, sp[0]); |
- Rename `JS_IsLooselyEqual` to `JS_IsEqual` - Rename `JS_IsStrictlyEqual` to `JS_IsStrictEqual` - Use stack instead of heap in `JS_IsEqual`
saghul
approved these changes
Apr 14, 2024
bnoordhuis
approved these changes
Apr 14, 2024
chqrlie
requested changes
Apr 14, 2024
- Use `int` instead of `JS_BOOL` as `JS_IsEqual` return type - Use `JS_VALUE_GET_BOOL` instead of `JS_ToBoolFree` in `JS_IsEqual`
chqrlie
approved these changes
Apr 15, 2024
bnoordhuis
reviewed
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS_IsLooselyEqualJS_IsStrictlyEqualJS_IsSameValueJS_IsSameValueZero