Skip to content

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Dec 14, 2023

No description provided.

@saghul saghul requested a review from bnoordhuis December 14, 2023 09:29
@bnoordhuis
Copy link
Contributor

I think we don't need -fwrapv, the ubsan buildbot should catch (and, in the past, has caught) instances of signed integer overflow.

@saghul
Copy link
Contributor Author

saghul commented Dec 14, 2023

I think we don't need -fwrapv, the ubsan buildbot should catch (and, in the past, has caught) instances of signed integer overflow.

Does it hurt to have it? I don't mind dropping that commit.

@saghul
Copy link
Contributor Author

saghul commented Dec 14, 2023

@bnoordhuis Added one last commit, PTAL.

Note I omitted this part bellard/quickjs@4bb8c35#diff-45f1ae674139f993bf8a99c382c1ba4863272a6fec2f492d76d7ff1b2cfcfbe2R31978 since we defined DUMP_BYTECODE 64 ourselves. Shall I rename our addition to 128 and keep the upstream one as 64?

@saghul saghul marked this pull request as ready for review December 14, 2023 09:57
@bnoordhuis
Copy link
Contributor

Does it hurt to have it?

It can. It inhibits some compiler optimizations around loops.

Shall I rename our addition to 128 and keep the upstream one as 64?

Sure, seems fine to me.

@saghul
Copy link
Contributor Author

saghul commented Dec 14, 2023

Does it hurt to have it?

It can. It inhibits some compiler optimizations around loops.

Shall I rename our addition to 128 and keep the upstream one as 64?

Sure, seems fine to me.

Ack, fixed both!

@saghul saghul merged commit e581286 into master Dec 14, 2023
@saghul saghul deleted the sync branch December 14, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants