Handle TypedArray detach during iteration #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Easiest reviewed with https://github.com/quickjs-ng/quickjs/pull/201/files?w=1 |
Per spec: detaching the TA mid-iteration is allowed and should not not throw an exception. In the case of TypedArray.prototype.set, because iteration over the source array is observable, we cannot bail out early when the TA is first detached.
bnoordhuis
force-pushed
the
fix-ta-iter-detach
branch
from
03ccd14 to
ceade35
Compare
|
I'm backing out the changes to TypedArray.prototype.sort for now. I need to investigate further where those UAFs come from. |
|
Cygwin again! |
saghul
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec: detaching the TA mid-iteration is allowed and should not not throw an exception.
In the case of TypedArray.prototype.set, because iteration over the source array is observable, we cannot bail out early when the TA is first detached.
In the case of TypedArray.prototype.sort that means we should not explicitly check for detachment and just handle it gracefully.