Replace JSValueConst with JSValue #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSValueConst was only used for the now removed CONFIG_CHECK_JSVALUE build mode. It is kept around as an alias for JSValue in quickjs.h to avoid breaking everyone's source builds but remove it everywhere else.
saghul
approved these changes
Dec 10, 2023
|
Removing JSValueConst discards ownership semantics. JSValue takes ownership while JSValueConst not. |
|
In normal builds it was equivalent. Or are you talking about the implied semantics? |
bluesky950520
pushed a commit
to bluesky950520/quickjs
that referenced
this pull request
Mar 14, 2025
Follow-up to quickjs-ng/quickjs#195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSValueConst was only used for the now removed CONFIG_CHECK_JSVALUE build mode. It is kept around as an alias for JSValue in quickjs.h to avoid breaking everyone's source builds but remove it everywhere else.
If you're wondering if this was a
perl -i -pe 's/JSValueConst/JSValue/g'oneliner - yes :)