Remove CONFIG_CHECK_JSVALUE build mode #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't produce a working build and I'm somewhat skeptical that its purported goal of catching reference counting bugs still works.
saghul
approved these changes
Dec 10, 2023
|
I have never used it myself, FWIW. |
bnoordhuis
commented
Dec 10, 2023
| } JSRefCountHeader; | ||
|
|
||
| #define JS_FLOAT64_NAN NAN | ||
| #define JSValueConst JSValue /* For backwards compatibility. */ |
There was a problem hiding this comment.
My plan is to follow up with a s/JSValueConst/JSValue/ PR and leave this to avoid breaking downstream users' builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't produce a working build and I'm somewhat skeptical that its purported goal of catching reference counting bugs still works.