Fix null pointer arithmetic UB in libregexp #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a patch I originally wrote for the Kiesel JS engine: https://codeberg.org/kiesel-js/kiesel/src/branch/main/patches/libregexp.patch
|
What regex did you use to trigger the bug? |
saghul
approved these changes
Nov 25, 2023
|
I don't remember, sorry. I think it popped up while running test262, crashing the runner with SIGILL. |
|
FWIW we are not seeing crashes when running teat262. @bnoordhuis thoughts? |
|
Yes, this was specific to using libregexp within my own engine (most likely because that uses LLVM via the zig toolchain) :) When I first investigated this someone suggested running an UBSAN-enabled build, feel free to check that way. |
bnoordhuis
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127.