Revert "Add ref-counted string slices (#1175)" #1185
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change seems to have introduced a seemingly impossible bug in a real-world code base where values flip to JS_NULL for no discernible reason. My best guess is something manipulating string data directly, without being aware of slice strings, but it's impossible to track down where. The weird thing is that the value flipping to null isn't even a string, it appears to be an array. This reverts commit 08db51a. This reverts commit 62b4eed. Fixes: quickjs-ng#1178
|
Thanks @bnoordhuis - I have checked out this PR locally and can confirm it causes the error I was seeing to go away. I will confirm again after merge just in case.
Just one point, at least based on just the error message I don't know about this, |
|
Found it! See #1186 for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seems to have introduced a seemingly impossible bug in a real-world code base where values flip to JS_NULL for no discernible reason.
My best guess is something manipulating string data directly, without being aware of slice strings, but it's impossible to track down where. The weird thing is that the value flipping to null isn't even a string, it appears to be an array.
This reverts commit 08db51a. This reverts commit 62b4eed.
Fixes: #1178