-
Notifications
You must be signed in to change notification settings - Fork 204
Port bellard/quickjs "dtoa library" commits #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have a fix for the first item in bnoordhuis/quickjs@2c073d7 that you can cherry-pick. |
Can you run make gen? Looks like we're one bug away! |
57ad718
to
45997cf
Compare
It turns out that I missed that the bellard/quickjs Something to keep a look out for in the future - any ports from bellard/quickjs that use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@bnoordhuis Anything else you're looking for to merge? (CI tests check out, and some local testing checks out fine as well.) EDIT: Rebased on latest master |
added new dtoa library to print and parse float64 numbers. It is necessary to fix corner cases (e.g. radix != 10) and to have correct behavior regardless of the libc implementation. Port of: bellard/quickjs@9936606 bellard/quickjs@dbbca3d Includes alternative fix for bellard/quickjs@638ec8c from 0191aea Update CMakeLists.txt and meson.build Co-Authored-By: Fabrice Bellard <[email protected]>
Re-apply quickjs-ng#319, use of js_number()
45997cf
to
ec59c5d
Compare
Port bellard/quickjs dtoa library commits
Port of:
bellard/quickjs@9936606
bellard/quickjs@dbbca3d
Includes alternative fix for bellard/quickjs@638ec8c from 0191aea
Remaining TODO items (would appreciate a look @saghul @bnoordhuis):
Codegen updateThis was actually a side effect of the root cause of the subsequent issue