Send Reset if the ResetTime elapsed in between checks #725
+298
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwilner
requested changes
Aug 7, 2025
session_state.go
Outdated
| session.ResetSeqTime.Minute() == now.Minute() && | ||
| session.ResetSeqTime.Second() == now.Second() { | ||
| // If we have crossed the reset time boundary in between checks, we send the reset | ||
| if session.LastCheckedResetSeqTime.Before(session.ResetSeqTime) && now.After(session.ResetSeqTime) && session.stateMachine.State.IsConnected() { |
There was a problem hiding this comment.
This will not work. The session.ResetSeqTime, when parsed with the short form string in the session factory, will correspond to the time of the parse only. It will not reflect "today's" reset seq time.
In addition, the last checked reset seq time should be initialized to zero, so this method needs to ensure that the last checked reset seq time must have been set previously before passing this condition
michaelwilner
requested changes
Aug 7, 2025
internal/session_settings.go
Outdated
| @@ -21,6 +21,7 @@ type SessionSettings struct { | |||
| TimeZone *time.Location | |||
| ResetSeqTime time.Time | |||
| EnableResetSeqTime bool | |||
| LastCheckedResetSeqTime time.Time | |||
There was a problem hiding this comment.
This is a session settings struct and this variable does not belong here
session_factory.go
Outdated
| @@ -388,6 +388,7 @@ func (f sessionFactory) newSession( | |||
| } | |||
| s.EnableResetSeqTime = true | |||
| s.ResetSeqTime = seqTime | |||
| s.LastCheckedResetSeqTime = seqTime | |||
michaelwilner
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.