Skip to content

Conversation

mirceapasoi
Copy link

@mirceapasoi mirceapasoi commented Jan 4, 2020

I'm using the DynamicSessions setting, but I'd like to allow users to connect multiple times using the same SenderCompID.

Right now, that's not possible because the Acceptor generates the SessionID without a Qualifier. I've added a new setting, such that when DynamicQualifier=Y, it will automatically add a distinct qualifier to dynamic session IDs.

@mirceapasoi
Copy link
Author

Tagging @cbusbey @reddec for reviews 🙏

Copy link
Contributor

@reddec reddec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can test it at Monday, but feels like should not have any negative impact.

@mirceapasoi
Copy link
Author

@cbusbey @reddec Friendly nudge on this

@cbusbey
Copy link
Contributor

cbusbey commented Jan 22, 2020

🤘 sorry for the delay, thanks for the contribution!

@cbusbey cbusbey merged commit 2381ebe into quickfixgo:master Jan 22, 2020
level2player pushed a commit to longbridge/quickfix that referenced this pull request Jul 19, 2022
Add DynamicQualifier setting to enable duplicate dynamic sessions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants