Skip to content

Fix a data race condition in the memoryStore #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Fix a data race condition in the memoryStore #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ type memoryStore struct {
messageMap map[int][]byte
}

func (store memoryStore) NextSenderMsgSeqNum() int {
func (store *memoryStore) NextSenderMsgSeqNum() int {
return store.senderMsgSeqNum + 1
}

func (store memoryStore) NextTargetMsgSeqNum() int {
func (store *memoryStore) NextTargetMsgSeqNum() int {
return store.targetMsgSeqNum + 1
}

Expand All @@ -62,7 +62,7 @@ func (store *memoryStore) SetNextTargetMsgSeqNum(nextSeqNum int) error {
return nil
}

func (store memoryStore) CreationTime() time.Time {
func (store *memoryStore) CreationTime() time.Time {
return store.creationTime
}

Expand Down Expand Up @@ -93,7 +93,7 @@ func (store *memoryStore) SaveMessage(seqNum int, msg []byte) error {
return nil
}

func (store memoryStore) GetMessages(beginSeqNum, endSeqNum int) ([][]byte, error) {
func (store *memoryStore) GetMessages(beginSeqNum, endSeqNum int) ([][]byte, error) {
var msgs [][]byte
for seqNum := beginSeqNum; seqNum <= endSeqNum; seqNum++ {
if m, ok := store.messageMap[seqNum]; ok {
Expand All @@ -106,9 +106,9 @@ func (store memoryStore) GetMessages(beginSeqNum, endSeqNum int) ([][]byte, erro
type memoryStoreFactory struct{}

func (f memoryStoreFactory) Create(sessionID SessionID) (MessageStore, error) {
var m memoryStore
m := new(memoryStore)
m.Reset()
return &m, nil
return m, nil
}

//NewMemoryStoreFactory returns a MessageStoreFactory instance that created in-memory MessageStores
Expand Down