Skip to content

Conversation

the-thing
Copy link
Contributor

Data dictionary validation is format independent now. The following tags are not allowed to be empty (with exception to <header/> and <trailer/> for FIX version 5.0 and higher).

  • <header/>
  • <trailer/>
  • <fields/>
  • <message/>
  • <messages/>

@chrjohn
Copy link
Member

chrjohn commented Mar 13, 2018

Hi @the-thing , thanks for the PR. There is a NPE in the SSLCertificateTest which should be unrelated but I also saw this once in my local environment.
The other error can be ignored, I assume it was because of the session reset at midnight.

@chrjohn chrjohn added this to the QFJ 2.0.1 milestone Mar 13, 2018
@the-thing
Copy link
Contributor Author

Hi Christoph,

It runs on my container ;)
https://travis-ci.org/the-thing/quickfixj/builds/352590390

I doubt that any of these test failures are related to this change. It's possible that there are still flaky tests in many areas. For example I often get errors on master branch for this particular test case

[ERROR] Failures:
[ERROR] SocketInitiatorTest.testInitiatorStopStartFileLog:184->doTestOfRestart:393->assertLoggedOn:488 Expected logon did not occur

https://travis-ci.org/the-thing/quickfixj/builds/352514755

I will try to debug some of these soon.

@chrjohn
Copy link
Member

chrjohn commented Mar 13, 2018

Hi Marcin,

OK, for further analysis I have activated the complete stacktrace in surefire, just in case it occurs again at some time in the future: 95184ad
W.r.t. the SocketInitiatorTest: it could be that this will be solved with #177 and/or #178 .

Thanks,
Chris.

@chrjohn chrjohn merged commit d920853 into quickfix-j:master Mar 13, 2018
chrjohn pushed a commit that referenced this pull request Mar 13, 2018
@the-thing the-thing deleted the QFJ-932 branch March 13, 2018 14:02
@chrjohn chrjohn modified the milestones: QFJ 2.0.1, QFJ 2.1.0 Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants