Skip to content

Cleanup Sessions on stop #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2018
Merged

Cleanup Sessions on stop #175

merged 2 commits into from
Mar 6, 2018

Conversation

chrjohn
Copy link
Member

@chrjohn chrjohn commented Feb 24, 2018 •
edited
Loading

  • added logic to unregister Session to Session.close() method
  • changed some tests to use try-with-resources on Session and to close used Sessions in general
  • changed Connector implementations to clean up used Sessions on stop
  • changed AbstractSocketInitiator to clean up internal map of initiators on stop
  • added Initiator/Acceptor tests to ensure Sessions are unregistered on stop

@chrjohn
- added logic to unregister Session to Session.close() method
ef0e76c 
 - changed some tests to use try-with-resources on Session
 - changed Connector implementations to clean up used Sessions on stop
 - changed AbstractSocketInitiator to clean up internal map of initiators on stop
@chrjohn chrjohn added this to the QFJ 2.1.0 milestone Feb 24, 2018
@chrjohn chrjohn merged commit 6b377f7 into master Mar 6, 2018
@chrjohn chrjohn deleted the session-cleanup branch March 6, 2018 20:19
@chrjohn chrjohn mentioned this pull request Jun 4, 2018
Merged
@chrjohn chrjohn mentioned this pull request Oct 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
QFJ 2.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@chrjohn