Dark mode styling #1658
Merged
Dark mode styling #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1658.quarto.org |
|
This looks great, thank you! I want to merge these changes right away so everyone gets the benefit, and then we'll work on the two todos.
|
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2025
* dark mode navbar and footer logos * homepage dark mode and spacing nudges * dark mode colors (cherry picked from commit d09a568)
|
Successfully created backport PR for |
2 tasks
cscheid
pushed a commit
that referenced
this pull request
May 8, 2025
* dark mode navbar and footer logos * homepage dark mode and spacing nudges * dark mode colors (cherry picked from commit d09a568) Co-authored-by: gregswinehart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses Posit's brand for dark mode colors, with AA WCAG color contrast in mind. It also includes some spacing nudges to the homepage, because designers gotta design, I guess. While that might sound concerning, it's pretty minor stuff... I just utilized bootstrap's grid classes to make things look nice at every breakpoint, which is obviously for both light or dark mode.
Additional thoughts:
I'm not sure how to swap out the navbar logo for a dark mode version. I tried
{.dark-content} {.light-content}, but it didn't work. The great news here is the current logo passes for accessibility for dark mode, so we can punt on this now if we need to. Having said that.... It barely passes. So I'd love to be able to swap to a much more accessible, dark mode logo as soon as we can.I'd love to suggest Shiny's light/dark mode switch, seen in the video below. The Shiny team says this component ready to be ported over whenever we have the time.
dark.mode.switch.mov