Skip to content

Fix notebook-view.url being ignored #13707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+4 −2
Merged

Fix notebook-view.url being ignored #13707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/changelog-1.8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## In this release

- ([#13694](https://github.com/quarto-dev/quarto-cli/issues/13694)): Fix `notebook-view.url` being ignored - external notebook links now properly use specified URLs instead of local preview files.

## In previous releases

- ([#13369](https://github.com/quarto-dev/quarto-cli/issues/13369)): Fix failure in theme compilation when `brand.color.primary` is specified for light or dark but not both.
Expand Down
2 changes: 1 addition & 1 deletion src/format/html/format-html-notebook-preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ export const notebookPreviewer = (
// to form links to this notebook
const nbPreview = {
title: resolvedTitle,
href: relative(inputDir, renderedNotebook[kHtmlPreview].hrefPath),
href: descriptor?.url || relative(inputDir, renderedNotebook[kHtmlPreview].hrefPath),
supporting,
resources,
order: work.order,
Expand Down
2 changes: 1 addition & 1 deletion tests/docs/smoke-all/2023/01/05/notebook-preview-complex.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ _quarto:
tests:
html:
ensureHtmlElements:
- ['a.quarto-notebook-link']
- ['a.quarto-notebook-link[href*="kaggle.com"]']
- ['div.quarto-alternate-notebooks a']
ensureFileRegexMatches:
- ['Source: TEST NB']
Expand Down
Loading