Fix the shell script indentation -- should be 4, not 2 #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the value for shell indentation, which was incorrectly set to 2. Also, streamline the comments at the top so that they are less verbose and visually assaulting.
In some places, the value of a linter configuration property should match the value of the editor configuration in `.editorconfig`. This is easily forgotten, so I added a comment to remind us. Also, I streamlined the introductory comments at the tops of the files to make them less verbose.
Add indentation for makefiles, including *.mk files.
pavoljuhas
reviewed
Sep 15, 2025
| @@ -41,6 +38,9 @@ indent_size = 4 | |||
| [{CMakeLists.txt,*.cmake}] | |||
| indent_size = 4 | |||
|
|
|||
| [{Makefile,makefile,*.mk}] | |||
| indent_size = 4 | |||
There was a problem hiding this comment.
Makefiles use TAB for indentation, please correct as in https://editorconfig.org/#example-file
pavoljuhas
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.editorconfig. It was incorrectly set to 2, and should be 4 instead..editorconfig..editorconfig. To help us remember this, I added appropriate comments to other config files.