test script for systemd validation #50

avisinone · 2025-05-27T06:53:57Z

No description provided.

smuppand · 2025-05-27T09:19:17Z

@avisinone Noticed that a few commits are duplicated in this PR (the same changes appear multiple times in the commit history). Please consider rebasing or squashing to remove the duplicates for a cleaner history. Also provide commit message. Also your run.sh is not aligned to run in the testkit suite. Refer https://github.com/smuppand/qcom-linux-testkit/blob/lib_changes/CONTRIBUTING.md

mwasilew · 2025-05-27T09:21:56Z

Rebasing your branch on top of main will fix the license issue. Last commit (e4bda8ffad71b14d891e46ec38e1985e85883bcb) in your branch is duplicated from main branch and that causes the problem.

Runner/suites/Platform/systemd/run.sh

smuppand

rebase your feature branch on top of latest main.
Unify PASS/FAIL results handling to reduce redundancy.
Along with left few more comments.

mwasilew

Please use indentation consistently and rewrite the commit message.

Runner/suites/Platform/systemd/run.sh

vnarapar · 2025-06-12T06:56:23Z

Runner/suites/Platform/systemd/run.sh

+update_test_fail(){
+    subtestname=$1
+    msg=$2
+    echo "$subtestname FAIL" >> "$res_file"


Can you please only add Over PASS/Fail status. Since this result file is getting parsed to get the test result, it might give wrong status?

Hi I have changed the result logic. please check

smuppand · 2025-06-23T06:59:26Z

Runner/suites/Platform/systemd/run.sh

+# shellcheck disable=SC1090,SC1091
+. "$TOOLS/functestlib.sh"
+
+TESTNAME="systemd"


Better to change name of the test. As it is doing for process check here.

smuppand · 2025-06-23T07:00:39Z

Runner/suites/Platform/systemd/run.sh

+
+# Call the functions
+check_systemd_pid
+check_systemctl_stop


Better move services check to different script. Any reason to club together?

vnarapar · 2025-07-02T06:37:09Z

Runner/suites/Platform/systemd/systemctlStop/run.sh

+        log_pass "Able to stop the service systemd-user-sessions with systemctl"
+        echo "$TESTNAME PASS" >> "$res_file"
+    fi
+    log_info "----------------------------------------------------"


Also is it required to add cleanup where in you restart the systemctl so that other tests wont get affected?

changed the test for systemctl start stop into one test to not have redundancy

vnarapar · 2025-07-02T06:42:17Z

Can you please add readme aswell

vnarapar · 2025-07-14T07:18:16Z

Runner/suites/Platform/systemd/checkFailedServices/run.sh

+    failed_services=$(systemctl --failed --no-legend --plain | awk '{print $1}')
+    if [ -z "$failed_services" ]; then
+        log_pass "No service is in failed state on device"
+        echo "$TESTNAME PASS" >> "$res_file"


Can you please give > instead of >> as this can append the results if new build is not flashed

vnarapar · 2025-07-14T07:18:22Z

Runner/suites/Platform/systemd/checkFailedServices/run.sh

+        log_fail "------ List of failed services --------"
+        log_fail "$failed_services"
+        log_fail "--------------------------------------"
+        echo "$TESTNAME FAIL" >> "$res_file"


Can you please give > instead of >> as this can append the results if new build is not flashed

vnarapar · 2025-07-14T07:18:33Z

Runner/suites/Platform/systemd/systemctlStartStop/run.sh

+    log_info "-------- Stopping systemd-user-sessions.service --------"
+    if ! systemctl is-active --quiet systemd-user-sessions.service; then
+        log_info "Service is not active before proceeding with stop command"
+        echo "$TESTNAME Fail" >> "$res_file"


Can you please give > instead of >> as this can append the results if new build is not flashed

Same applies to others aswell

@smuppand Can you please confirm should i change it back to overwriting the result file?

vnarapar · 2025-07-14T07:20:53Z

Runner/suites/Platform/systemd/README.md

@@ -0,0 +1,27 @@
+# systemd Suite


Please add readme for each test for consistency

vnarapar

LGTM

github-actions · 2025-08-15T02:15:39Z

This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

smuppand · 2025-09-19T08:53:58Z

@avisinone Can you review the errors, resolve them, and upload an updated patch? Please include a more detailed PR description, explaining why this test is necessary and outlining what it will cover.

github-actions · 2025-10-20T02:13:35Z

This pull request has been marked as stale due to 30 days of inactivity. To prevent automatic closure in 7 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

vnarapar · 2025-10-24T10:45:45Z

@avisinone please fix the checkers

Following check are implemented : systemdPID\run.sh Check systemd starts with PID 1. systemctlStartStop\run.sh Check if systemctl is able to start and stop a service. CheckFailedServices\run.sh Check for failed service on device using systemctl status. Usage Command Verified : ./run-test.sh systemPID ./run-test.sh systemctlStartStop ./run-test.sh CheckFailedServices Signed-off-by: Abhishek Sinha <[email protected]>

vnarapar

LGTM

smuppand · 2025-10-28T16:06:23Z

Runner/suites/Platform/systemd/checkFailedServices/run.sh

+        echo "$TESTNAME PASS" > "$res_file"
+    else
+        log_fail "------ List of failed services --------"
+        log_fail "$failed_services"


There may be several service failures during the boot process for different reasons. Instead of failing the process for all such cases, could we create a list of mandatory service names and monitor only those? We can then base the test outcome on the status of this mandatory list.

avisinone requested review from mwasilew, smuppand and vnarapar May 27, 2025 09:12

This comment was marked as outdated.

Sign in to view

avisinone force-pushed the platform_test branch from ae53f2b to bb77bbe Compare June 5, 2025 10:30

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand reviewed Jun 5, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

smuppand requested changes Jun 5, 2025

View reviewed changes

avisinone force-pushed the platform_test branch from e0a1e81 to 6cade03 Compare June 5, 2025 12:40

avisinone requested a review from smuppand June 5, 2025 12:41

mwasilew requested changes Jun 6, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

avisinone force-pushed the platform_test branch 2 times, most recently from 0cb77ff to 6bbb509 Compare June 10, 2025 10:44

avisinone requested a review from mwasilew June 10, 2025 10:46

vnarapar reviewed Jun 10, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

avisinone force-pushed the platform_test branch from 6bbb509 to 61c65fb Compare June 10, 2025 16:17

vnarapar reviewed Jun 12, 2025

View reviewed changes

Runner/suites/Platform/systemd/run.sh Outdated Show resolved Hide resolved

vnarapar reviewed Jun 12, 2025

View reviewed changes

avisinone force-pushed the platform_test branch 2 times, most recently from a5e8847 to dbc44a0 Compare June 23, 2025 06:48

smuppand reviewed Jun 23, 2025

View reviewed changes

vnarapar reviewed Jul 2, 2025

View reviewed changes

avisinone force-pushed the platform_test branch from 550d355 to cc45795 Compare July 11, 2025 10:09

vnarapar reviewed Jul 14, 2025

View reviewed changes

Runner/suites/Platform/systemd/README.md

@@ -0,0 +1,27 @@

# systemd Suite

Copy link

Contributor

vnarapar Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add readme for each test for consistency

avisinone force-pushed the platform_test branch 3 times, most recently from 33900ac to 35faa4b Compare July 14, 2025 13:56

vnarapar previously approved these changes Jul 15, 2025

View reviewed changes

avisinone requested a review from smuppand July 15, 2025 09:53

github-actions bot added the Stale label Aug 15, 2025

github-actions bot closed this Aug 23, 2025

vnarapar reopened this Sep 19, 2025

github-actions bot removed the Stale label Sep 20, 2025

github-actions bot added the Stale label Oct 20, 2025

avisinone dismissed vnarapar’s stale review via d752ca2 October 24, 2025 12:30

avisinone force-pushed the platform_test branch from aa2213c to d752ca2 Compare October 24, 2025 12:30

avisinone force-pushed the platform_test branch from c205617 to c04548d Compare October 24, 2025 12:39

github-actions bot removed the Stale label Oct 25, 2025

vnarapar approved these changes Oct 27, 2025

View reviewed changes

vnarapar self-requested a review October 27, 2025 18:24

vnarapar approved these changes Oct 27, 2025

View reviewed changes

smuppand requested changes Oct 28, 2025

View reviewed changes

test script for systemd validation #50

Are you sure you want to change the base?

test script for systemd validation #50

Uh oh!

Conversation

avisinone commented May 27, 2025

Uh oh!

This comment was marked as outdated.

smuppand commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwasilew commented May 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smuppand left a comment

Choose a reason for hiding this comment

Uh oh!

mwasilew left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vnarapar commented Jul 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vnarapar left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

smuppand commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

vnarapar commented Oct 24, 2025

Uh oh!

vnarapar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

smuppand commented May 27, 2025 •

edited

Loading

smuppand commented Sep 19, 2025 •

edited

Loading