-
Notifications
You must be signed in to change notification settings - Fork 7
Adds HEAD request functionality with http_head #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just doing some testing on my end and my use case is to do up to hundreds of HEAD requests at a time. I'm seeing segmentation faults in some cases, and in general it would be good to have a progress bar on this. This is outside of the scope of this change, but I'm curious what your thoughts are on that. |
@thomascjohnson we'll familiarize with the change and run some tests to form suggestions/feedback |
To follow up on the seg faults, it's caused by URLs that can't connect and the headers being processed when they aren't available in the result. Just pushed a fix for that. I also fixed the issue with decomposition declarations. |
FYI The build failures do not appear to be the code's fault - I'll restart the jobs to confirm. EDIT: tests passing |
Thanks @lmangani! Looks like some of those URLs can be flaky? Any thoughts on adding tests with the extension httpserver? |
yes indeed. We need a better public service for testing. |
Thanks Lorenzo, I was actually trying to setup something for testing yesterday but it's challenging with the DuckDB testing framework. |
@thomascjohnson i'm redesigning the test but i didn't wanna hold your PR back, unless you still have changes to add. We can re-add the tests all together once its merged and pick a more reliable target, although issues are always possible in actions. |
Merged! Thanks for your contribution @thomascjohnson 💯 I'll go ahead and rebuild the tests on a separate PR. |
@thomascjohnson duckdb/community-extensions#516 publishing! |
Added as a result of this issue: #20
This needs some cleanup due to the difference in response values for HEAD compared to GET and POST.