Skip to content

fixed Feature that contains only undefined/skipped scenarios is displ… #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2023
Merged

fixed Feature that contains only undefined/skipped scenarios is displ… #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# 0.14.4
- fixed [Feature that contains only undefined/skipped scenarios is displayed as passed](https://github.com/qavajs/html-formatter/issues/36)

# 0.14.3
- fixed width and height of error and logs overlay

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@qavajs/html-formatter",
"version": "0.14.3",
"version": "0.14.4",
"main": "formatter/formatter.js",
"scripts": {
"report:compile": "node test/compile_report.js",
Expand Down
2 changes: 1 addition & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const data = window.sourceData
total: feature.elements.length,
elements: feature.elements.map((scenario: any) => ({
...scenario,
isFailed: scenario.steps.some((step: any) => step.result.status === 'failed')
isFailed: scenario.steps.some((step: any) => step.result.status !== 'passed')
})),
}))
.map((feature: any) => ({
Expand Down
6 changes: 3 additions & 3 deletions test-e2e/features/FeaturePage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ Feature: Feature Page

Scenario: verify that user can filter only failed on feature page
When I click 'Feature > Show Only Failed'
Then I expect number of elements in 'Feature > Scenarios' collection to be equal '3'
Then I expect number of elements in 'Feature > Scenarios' collection to be equal '6'
And I expect text of 'Feature > #1 of Scenarios > Title' to be equal 'Scenario: scenario failed'

Scenario: verify that filter state is saved
When I click 'Feature > Show Only Failed'
Then I expect number of elements in 'Feature > Scenarios' collection to be equal '3'
Then I expect number of elements in 'Feature > Scenarios' collection to be equal '6'
And I expect text of 'Feature > #1 of Scenarios > Title' to be equal 'Scenario: scenario failed'
When I refresh page
Then I expect number of elements in 'Feature > Scenarios' collection to be equal '3'
Then I expect number of elements in 'Feature > Scenarios' collection to be equal '6'
And I expect text of 'Feature > #1 of Scenarios > Title' to be equal 'Scenario: scenario failed'