Skip to content

Fix software tests, the recently added pytest.skip was wrong #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix software tests, the recently added pytest.skip was wrong #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/test_cratedb_pandas_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import sys

import pandas as pd
import pytest
import sqlalchemy as sa
Expand All @@ -8,7 +10,8 @@
SQL_SELECT_STATEMENT = "SELECT mountain, height FROM sys.summits ORDER BY height DESC LIMIT 1;"


pytest.skip("Does not work on Python 3.7", allow_module_level=True)
if sys.version_info < (3, 8):
pytest.skip("Does not work on Python 3.7", allow_module_level=True)


def test_crate_read_sql(cratedb_http_host, cratedb_http_port):
Expand Down
5 changes: 4 additions & 1 deletion tests/test_cratedb_pandas_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import sys

import pandas as pd
import pytest
import sqlalchemy as sa
Expand All @@ -9,7 +11,8 @@
SQL_REFRESH_STATEMENT = "REFRESH TABLE doc.foo;"


pytest.skip("Does not work on Python 3.7", allow_module_level=True)
if sys.version_info < (3, 8):
pytest.skip("Does not work on Python 3.7", allow_module_level=True)


def test_crate_to_sql(cratedb_http_host, cratedb_http_port):
Expand Down