Skip to content

Make v2.utils private. #7863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2023
Merged

Make v2.utils private. #7863

merged 3 commits into from
Aug 22, 2023

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 22, 2023 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 22, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7863

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures, 2 Unrelated Failures

As of commit 456250b with merge base 9c4f738 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vfdev-5
vfdev-5 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamped ✉️

pmeier
pmeier approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@NicolasHug NicolasHug merged commit 26ed129 into pytorch:main Aug 22, 2023
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2023
@NicolasHug @facebook-github-bot
[fbsync] Make v2.utils private. (#7863)
dca5b0a 
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: matteobettini

Differential Revision: D48900397

fbshipit-source-id: 8271d35783c58b979ae6cce041854b59bde98e9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

@pmeier pmeier pmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed code quality module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NicolasHug @vfdev-5 @pmeier @facebook-github-bot