Skip to content

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Aug 10, 2023

Old tests were terrible, new tests were OK but all were skipped anyway.
Now that we always test and ship against turbo (#7672), our jpeg encoding/decoding should be aligned with PIL's, and we should be able to bring back the relevant tests.

Closes #5941
Closes #3913
Closes #6563
Closes #5184
Closes #5162

cc @pmeier

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 10, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7820

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 8 New Failures

As of commit 432347f:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NicolasHug NicolasHug merged commit 8768131 into pytorch:main Aug 10, 2023
facebook-github-bot pushed a commit that referenced this pull request Aug 25, 2023
Reviewed By: matteobettini

Differential Revision: D48642289

fbshipit-source-id: ed260d88c890851048298b1afbe42d52014d0139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build against libjpeg-turbo instead of libjpeg fix JPEG reference tests Fix jpeg encoding tests on windows

3 participants