-
Notifications
You must be signed in to change notification settings - Fork 7.2k
move passthrough for unknown types from dispatchers to transforms #7804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
56ae0ab
move passthrough for unknown types from dispatchers to transforms
pmeier 044e6d1
implement noop behavior for transforms
pmeier 6421d25
Merge branch 'main' into no-passthrough-dispatchers
pmeier 38f85c5
simplify error message
pmeier 9f51230
inline kernel call
pmeier c0c2517
fix test
pmeier 99bf83f
noop -> passthrough
pmeier 159a1d9
Merge branch 'main' into no-passthrough-dispatchers
pmeier 84af424
Revert "inline kernel call"
pmeier afd48df
_call_or_noop -> _call_kernel
pmeier 75f46e7
Merge branch 'main' into no-passthrough-dispatchers
pmeier 06d422f
fix tests
pmeier c95439d
Merge branch 'main' into no-passthrough-dispatchers
pmeier 84dc2bf
remove obsolete test
pmeier 127e3bd
move passthrough warning to transforms
pmeier 8932f74
Merge branch 'main' into no-passthrough-dispatchers
pmeier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We remove this test, because it never checked correctness, but rather if the specific dispatchers were being called. Due to our new architecture, they are never called and thus this test fails.
The same argument applies to the removed tests in
test/test_transforms_v2.py.