Skip to content

undeprecate to_grayscale #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2023
Merged

undeprecate to_grayscale #7707

merged 2 commits into from
Jun 28, 2023
+9 −12

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Jun 28, 2023 •
edited by pytorch-bot bot
Loading

@pmeier pmeier requested a review from NicolasHug June 28, 2023 11:19
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7707

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures

As of commit daea792:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

NicolasHug
NicolasHug approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Philip, LGTM (looks like there's a bunch of unrelated failures for now)

@NicolasHug
Copy link
Member

NicolasHug commented Jun 28, 2023

Might be worth amending this past comment from me BTW

vision/torchvision/transforms/functional.py

Line 1251 in 25c8a3a

# bothered to dig. Anyway, this can be deprecated as we migrate to V2.

@pmeier pmeier merged commit 1c1cd68 into pytorch:main Jun 28, 2023
@pmeier pmeier deleted the to-grayscale branch June 28, 2023 20:46
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Jul 3, 2023
@NicolasHug @facebook-github-bot
[fbsync] undeprecate to_grayscale (#7707)
bbe1913 
Reviewed By: vmoens

Differential Revision: D47186570

fbshipit-source-id: 0eb63c260c9c154aa5968f22de971e5486fea589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed deprecation module: transforms

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmeier @NicolasHug @facebook-github-bot