fix mypy #7685
Merged
fix mypy #7685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
added
the
other
NicolasHug
approved these changes
Jun 21, 2023
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks for the fix Philip.
lmfao at the "error" though. Thanks mypy, as usual.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
Reviewed By: vmoens Differential Revision: D47186587 fbshipit-source-id: a77c300da806c98f5a6679b97cc462f5be218997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error comes from a
mypyupdate that includes python/typeshed#9891. Basically, nowmypyknows that a module does not need to have a__file__attribute (esoteric, but you can create modules at runtime withtypes.ModuleType). We can just silence it here, since we are sure that the modules we are working are always the real thing.