Fix: don't call round() on float images for ResizeV2 #7669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7669
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
commented
Jun 13, 2023
| img = torch.randint(0, 256, size=(1, 3, 100, 100), dtype=torch.float16) | ||
| out = F.resize(img, size=(10, 10)) | ||
| assert out.dtype == torch.float16 | ||
| assert (out.round() - out).sum() > 0 |
vfdev-5
approved these changes
Jun 13, 2023
Contributor
vfdev-5
left a comment
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks for the fix and catching that, lgtm !
Member
Author
|
There are some failures but the current CI makes it impossible to see them. The hud doesn't seem to be working either. Most test jobs are passing anyway so I"ll merge . |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Reviewed By: vmoens Differential Revision: D46724116 fbshipit-source-id: 91eb40da4f1ecf03e81b97bcf5e220428f52997e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7667
cc @vfdev-5