Skip to content

ci: Limit macOS testing to one version of python #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: Limit macOS testing to one version of python #7507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
327bc09
ci: Limit macOS testing to one version of python
seemethere Apr 7, 2023
4a387eb
Add note why 3.8 is important
seemethere Apr 7, 2023
45806db
update for minimum versions
seemethere Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ jobs:
unittests:
strategy:
matrix:
python-version:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
runner: ["macos-12"]
include:
# Test against the most popular version of Python (at the time of commit 40% of torch downloads use 3.8)
Copy link
Contributor

@pmeier pmeier Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same for Windows as well? Meaning, only Linux will have the full 3.7 to 3.11 coverage?

- python-version: "3.8"
runner: macos-m1-12
runner: "macos-12"
# Minimum version available for Apple Silicon is 3.9, so just use that
Copy link
Contributor

@pmeier pmeier Apr 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been testing against 3.8 before, so this can't be the whole truth? Could you clarify this?

- python-version: "3.9"
runner: "macos-m1-12"
fail-fast: false
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
with:
Expand Down