Add device check to io.decode_image
#7406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only works for CPU tensors, so raise an error if called with non-CPU tensor
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/7406
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Mar 9, 2023
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @malfet , some suggestion below but I'll approve to unblock the cherry-picking
Co-authored-by: Nicolas Hug <[email protected]>
NicolasHug
reviewed
Mar 9, 2023
| @needs_cuda | ||
| def test_decode_image_cuda_raises(): | ||
| data = torch.randint(0, 127, size=(255,), device="cuda", dtype=torch.uint8) | ||
| exception_raised = True |
Member
There was a problem hiding this comment.
Nit: this can be removed now
Suggested change
| exception_raised = True |
Contributor
There was a problem hiding this comment.
This shouldn't be a nit, since (amongst other things) it breaks the lint workflow: https://app.circleci.com/jobs/github/pytorch/vision/1851401
|
Hey @malfet! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Summary: Co-authored-by: Nicolas Hug <[email protected]> Reviewed By: vmoens Differential Revision: D44416571 fbshipit-source-id: 9009b4353c3b5a18df8fb7688a92614e49f7a661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only works for CPU tensors, so raise an error if called with non-CPU tensor
Add unit test to validate for that
Followups: one also needs to check that tensors passed to this function is contiguous
Fixes #7391