Skip to content

Updated geometric transforms v2 docstring #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 23, 2023
Merged

Updated geometric transforms v2 docstring #7303

merged 9 commits into from
Feb 23, 2023

Conversation

@vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Feb 22, 2023 •
edited
Loading

  • Updated geometry transforms v2 docstrings
  • Added new docstrings for the new transforms

@vfdev-5 vfdev-5 changed the title Update geom docs Updated geometric transforms v2 docstring Feb 22, 2023
@vfdev-5 vfdev-5 marked this pull request as ready for review February 22, 2023 16:41
@vfdev-5 vfdev-5 requested review from NicolasHug and pmeier February 23, 2023 11:05
NicolasHug
NicolasHug approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @vfdev-5 , the docs look great. I only have minor comments/nits below, LGTM!

@pmeier
Copy link
Contributor

pmeier commented Feb 23, 2023

Rendered

pmeier
pmeier reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Victor, I left a bunch of comments. We should really looking into composing the docstrings in the future to avoid all this copy pasting.

@vfdev-5 vfdev-5 requested a review from pmeier February 23, 2023 16:30
pmeier
pmeier approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendered. Nothing stands out. Thanks Victor!

@vfdev-5 vfdev-5 merged commit 31a4ef9 into pytorch:main Feb 23, 2023
@vfdev-5 vfdev-5 deleted the update-geom-docs branch February 23, 2023 16:57
@github-actions
Copy link

Hey @vfdev-5!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

NicolasHug added a commit to NicolasHug/vision that referenced this pull request Feb 24, 2023
@vfdev-5 @NicolasHug @pmeier
Updated geometric transforms v2 docstring (pytorch#7303)
684f8d2 
Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2023
@NicolasHug @pmeier @facebook-github-bot
[fbsync] Updated geometric transforms v2 docstring (#7303)
d0daf14 
Summary:

Reviewed By: vmoens

Differential Revision: D44416617

fbshipit-source-id: eff95946616f690bbc97ad2fd24cedcec937cb96

Co-authored-by: Nicolas Hug <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

+1 more reviewer

@pmeier pmeier pmeier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed module: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vfdev-5 @pmeier @NicolasHug @facebook-github-bot