Skip to content

restore silent fill None -> 0 on transformations #7272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

restore silent fill None -> 0 on transformations #7272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d1b76
restore silent fill None -> 0 on transformations
pmeier Feb 16, 2023
7fa38b0
add comment
pmeier Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions torchvision/transforms/v2/_geometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,10 @@ def __init__(
self.interpolation = _check_interpolation(interpolation)
self.expand = expand

# This is just here for BC
# TODO: investigate if this actually has a significant effect on model acc
if fill is None:
fill = 0
self.fill = fill
self._fill = _setup_fill_arg(fill)

Expand Down Expand Up @@ -396,6 +400,11 @@ def __init__(
self.shear = shear

self.interpolation = _check_interpolation(interpolation)

# This is just here for BC
# TODO: investigate if this actually has a significant effect on model acc
if fill is None:
fill = 0
self.fill = fill
self._fill = _setup_fill_arg(fill)

Expand Down Expand Up @@ -568,6 +577,11 @@ def __init__(

self.distortion_scale = distortion_scale
self.interpolation = _check_interpolation(interpolation)

# This is just here for BC
# TODO: investigate if this actually has a significant effect on model acc
if fill is None:
fill = 0
self.fill = fill
self._fill = _setup_fill_arg(fill)

Expand Down