Skip to content

raise kernel launch errors instead of just print #7080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2023
Merged

raise kernel launch errors instead of just print #7080

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
535c7c0
raise kernel launch errors instead of just print
ppwwyyxx Jan 12, 2023
c184a75
Merge branch 'main' into main
ppwwyyxx Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions torchvision/csrc/ops/cuda/deform_conv2d_kernel.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,11 +300,7 @@ void deformable_im2col(
data_col.data_ptr<scalar_t>());
}));
}

cudaError_t err = cudaGetLastError();
if (err != cudaSuccess) {
printf("error in deformable_im2col: %s\n", cudaGetErrorString(err));
}
C10_CUDA_KERNEL_LAUNCH_CHECK();
}

int get_greatest_divisor_below_bound(int n, int bound) {
Expand Down Expand Up @@ -483,11 +479,7 @@ void compute_grad_input(
grad_im.data_ptr<scalar_t>());
}));
}

cudaError_t err = cudaGetLastError();
if (err != cudaSuccess) {
printf("error in compute_grad_input: %s\n", cudaGetErrorString(err));
}
C10_CUDA_KERNEL_LAUNCH_CHECK();
}

template <typename scalar_t, typename index_t>
Expand Down Expand Up @@ -736,12 +728,7 @@ void compute_grad_offset_and_mask(
grad_mask.data_ptr<scalar_t>());
}));
}

cudaError_t err = cudaGetLastError();
if (err != cudaSuccess) {
printf(
"error in compute_grad_offset_and_mask: %s\n", cudaGetErrorString(err));
}
C10_CUDA_KERNEL_LAUNCH_CHECK();
}

std::tuple<at::Tensor, at::Tensor, at::Tensor> backward_gradient_inputs(
Expand Down