fix prototype dataset imagenet mock data #7009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
force-pushed
the
imagenet-mock-data
branch
from
d75e916 to
7cafb5f
Compare
ejguan
approved these changes
Dec 5, 2022
Contributor
ejguan
left a comment
ejguan
left a comment
There was a problem hiding this comment.
Thank you for the quick fix
Contributor
Author
|
macOS CI seems stuck, but since everything else is green, I think we can move forward here. |
This reverts commit 7cafb5f.
|
Hey @pmeier! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
Summary: * fix prototype dataset imagenet mock data * [REVERT ME] temporarily add prototype datasets test to CI * Revert "[REVERT ME] temporarily add prototype datasets test to CI" This reverts commit 7cafb5f. Reviewed By: datumbox Differential Revision: D41836895 fbshipit-source-id: bc6ae8b90f0220ea321f33d3231bb0a150c23e30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported offline by @ejguan. We previously ignored a warning there thinking that it was actually
scipy.io.savematthat is causing it. Turns out, we were providing deprecated input data and starting withnumpy=1.24this fails. This is visible intorchdataCI, e.g. https://github.com/pytorch/data/actions/runs/3579763020.I've temporarily expanded the prototype test matrix to cover all cases.
cc @bjuncek