Cleanup prototype transforms tests #6984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Nov 28, 2022
| *, | ||
| agg_method=None, | ||
| allowed_percentage_diff=None, | ||
| mae=False, |
Contributor
Author
There was a problem hiding this comment.
I ported both agg_method and allowed_percentage diff from the stable tests. In the prototype tests we only ever used agg_method="mean". This just makes it more expressive by adding an mae=False flag instead.
|
|
||
|
|
||
| def make_info_args_kwargs_parametrization(infos, *, args_kwargs_fn, condition=None): | ||
| if condition is None: |
Contributor
Author
There was a problem hiding this comment.
There is no need to have a condition that filters infos here, if we can simply filter them before passing them here.
| expected, | ||
| **info.get_closeness_kwargs(test_id, dtype=input.dtype, device=input.device), | ||
| msg=parametrized_error_message(*other_args, *kwargs), | ||
| msg=parametrized_error_message(*other_args, **kwargs), |
Contributor
Author
There was a problem hiding this comment.
I botched this when I introduced the extra information. Without the ** we would only include the names of the parameters rather than the name-value-pair.
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Summary: * minor cleanup of the prototype transforms tests * refactor ImagePair * pretty format enum Reviewed By: YosuaMichael Differential Revision: D41648543 fbshipit-source-id: 7d7aacda750d994ad6bfa22f42dec92b18e16ccc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some minor thing in the prototype transforms test suite. I'm going to highlight them with inline comments.
cc @vfdev-5 @datumbox @bjuncek